[Hallmark] Give full-player expand/collapse spatial continuity and predictive Back #102
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Purpose
Make the mini-player → full-player transition communicate that these are two presentations of the same playback session.
Related hierarchy work: #96 mini-player and #97 full-player controls. App-wide route/motion language is tracked separately.
Reviewed against current
mainatf9f7feba8e7bb499c6001bf0cc19a38357b7494aon 2026-09-27.Current behavior
MainActivityconditionally inserts/removesFullPlayerwhenisExpandedchanges.FullPlayeruses a normalBackHandlerthat collapses it.The architecture is good:
Keep that architecture.
The missing part is visual/gesture continuity.
Proposed transition
Expand
Mini-player → full player:
The mini-player should not perform an unrelated exit flourish underneath the player.
Collapse
Reverse the spatial relationship:
Do not build an elaborate all-controls morph as the first implementation.
Predictive Back
Replace/augment the all-or-nothing custom Back interception with predictive-back-aware collapse on supported Android versions.
The edge gesture should:
Toolbar collapse and system Back must end in the same state.
Possible later continuity
After #96/#97 stabilize layouts, evaluate whether the cover artwork alone should participate in stronger shared spatial continuity between mini and full player.
Do not block this issue on a shared-element implementation. A clean surface transition is the acceptance baseline.
State interactions
Verify:
Opening a modal sheet from the full player must not collapse the player.
If playback stops and the player currently collapses automatically, preserve that product behavior unless a separate issue changes it.
Accessibility / reduced motion
Implementation starting points
app/src/main/kotlin/com/example/shelfplayer/MainActivity.kt— player overlay ownershipapp/src/main/kotlin/com/example/shelfplayer/feature/player/FullPlayer.kt— Back handling and player surfaceapp/src/main/kotlin/com/example/shelfplayer/feature/player/MiniPlayer.ktonly as required to coordinate stateAcceptance
Hallmark Slice 1 — design/readiness
Current
mainaudit at8ea2122fc3c1d32bcfc5f0eb295b3521be562ed4:MainActivityowns the full-player overlay,PlayerSurfaceowns expanded/collapsed state, and the player is not a NavHost destination.if (isExpanded)inserts/removesFullPlayer;FullPlayeruses ordinaryBackHandler.Slice change:
PlayerSurface.collapse()final state.Expected files:
MainActivity.ktFullPlayer.ktonly as required for presentation/back coordinationPlayerMotion.ktAccessibility/reduced motion:
Hallmark Slice 1 — implementation staged
Branch:
mcp/hallmark-slice-1-playerBase:
8ea2122fc3c1d32bcfc5f0eb295b3521be562ed4Current HEAD:
f4f90f10a624e310cb87d6abe20482aea444bcb2Implemented for #102:
MainActivityoverlay backed by the existing singletonPlayerSurface; no NavHost destination was introduced;PredictiveBackHandlerconsumes gesture progress directly and translates/fades the full-player layer with the gesture;actions.onCollapsepath as toolbar collapse;Tests were added/updated for
PlayerSurfaceownership and normal Android Back resolving through the same collapse callback. Predictive gesture-progress quality remains a physical/device acceptance item.Verification note: no automated checks or workflow runs were started, per owner instruction.