[Bug] History should record playback stop events on pause and sleep-timer expiry #44
Loading…
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Classification
Playback-history correctness / product-behavior field report.
Observed on device after GitHub PR #93 was merged. This issue is being logged separately from the headset cold-resume regression because the underlying ownership and acceptance criteria are different.
Field report
Playback History shows Play events, but the listener also needs to see when that listening interval stopped.
At minimum, History should show a stop/end event when:
The observed History did not provide that end-of-listening information clearly/reliably.
Product intent
History is meant to answer what happened to this audiobook and when. A Play row without a corresponding end marker makes a listening interval incomplete and makes it harder to reconstruct where/why playback stopped.
The user-facing concept should be clear: playback stopped here, with the cause represented where useful (ordinary pause vs sleep timer). Avoid producing multiple confusing rows for the same physical stop.
Current repository state
The underlying model already has much of this intent:
PlaybackEvent.Play;PlaybackEvent.Pause;PlaybackEvent.SleepTimerExpired;PlaybackEvent.SleepTimerStarted/SleepTimerExtended/SleepTimerRewind.HistorySheetalready has labels/icons for bothPauseandSleepTimerExpired.PlaybackServicerecords Play/Pause fromonPlayWhenReadyChanged, deliberately usingplayWhenReadyrather thanisPlayingso buffering does not look like a stop.SleepTimerController.expire()currently callsplayer.pause()and then recordsSleepTimerExpired.Therefore this is not a request to invent a second history/logging architecture. The tree already expresses the intended events, but the device result says the actual persisted/rendered history does not reliably communicate the end of playback.
Investigation scope for eventual implementation
Determine whether the missing stop/end row is caused by:
Do not add a parallel recorder just to make a row appear. Playback transition ownership should remain in the service/player boundary that already owns these events.
Expected behavior
Every locally owned transition from active listening to stopped/paused should leave one clear, durable playback-end marker in History at the final position.
For sleep-timer expiry, History must make it clear that the timer caused playback to stop. Whether the final implementation models this as a generic
Stopwith a cause or keepsPause/SleepTimerExpiredas distinct event types is an implementation detail, provided the timeline is unambiguous and does not duplicate the same stop misleadingly.Acceptance criteria
PauseandSleepTimerExpiredare both retained internally for one timer expiry, the UI must not present them as two unrelated stops for one transition.Related
0:00