Streamline Forgejo CI verification #52

Merged
alexander merged 9 commits from mcp/ci-gate-efficiency into main 2026-09-18 18:08:45 +02:00
Owner

Summary

Streamline the Forgejo acceptance gate now that the CI migration is complete.

The PR keeps the current manual-only PR verification model, but removes duplicated expensive work and restores checks that were accidentally tied to pull_request events.

Changes

  • keep .forgejo/workflows/pull-request.yml manual-only;
  • compare manual runs against current origin/main and reject stale/unrebased heads;
  • classify build/classpath changes before Android work;
  • run one authoritative verifyDebug pass:
    • ordinary changes: normal verification;
    • build/classpath changes: --rerun-tasks for R-31;
    • optional force_rerun input for reviewer-requested full reruns;
  • restore the committed Room-schema immutability check for manual runs;
  • require policy, wrapper, secret scan, and schema checks before Android verification starts;
  • generate the dependency report inside the already-warmed verification job instead of starting a second Android job;
  • remove the second standalone classpath-rerun job;
  • add BOOKWAVE_CODEX_PREWARM=none so CI does not run a redundant gradlew help before the real Gradle command;
  • keep four Gradle workers;
  • set cancel-in-progress: false for the manually-started acceptance workflow so a second click queues rather than terminating an expensive run;
  • retain current push-main behavior: fast-forward merges do not immediately repeat the accepted debug gate, while manual/scheduled Main remains standalone and runs verifyDebug;
  • update release documentation to describe the Forgejo CI contract.

Validation

Validated on exact HEAD:

0b18ca9332a97c2231c370532adf97c770402b39

Forgejo Actions run #50 / workflow run object 52:

  • result: success;
  • total wall time: 13m05s;
  • policy correctly classified this PR as a build/classpath change;
  • verification mode: full rerun;
  • verifyDebug --rerun-tasks: BUILD SUCCESSFUL in 11m41s;
  • 1,184 actionable tasks, 1,184 executed;
  • Gradle wrapper validation: passed;
  • gitleaks 8.30.1: passed, no leaks;
  • committed Room schemas immutable: passed;
  • dependency report uploaded;
  • Room schemas uploaded;
  • quality reports uploaded;
  • debug APK uploaded.

Previous full manual PR acceptance run took 26m18s, because it performed a normal verifyDebug, bootstrapped a separate dependency-report job, and then performed another complete verifyDebug --rerun-tasks.

This candidate therefore removes the duplicate verification while retaining the R-31 full-rerun guarantee when it is actually required.

Scope

This PR deliberately does not add a custom Android CI image or persistent Gradle cache. Those are good follow-up optimizations and can be measured independently after this workflow simplification is merged.

No merge requested; owner will review and merge manually.

## Summary Streamline the Forgejo acceptance gate now that the CI migration is complete. The PR keeps the current **manual-only** PR verification model, but removes duplicated expensive work and restores checks that were accidentally tied to `pull_request` events. ### Changes - keep `.forgejo/workflows/pull-request.yml` manual-only; - compare manual runs against current `origin/main` and reject stale/unrebased heads; - classify build/classpath changes before Android work; - run **one** authoritative `verifyDebug` pass: - ordinary changes: normal verification; - build/classpath changes: `--rerun-tasks` for R-31; - optional `force_rerun` input for reviewer-requested full reruns; - restore the committed Room-schema immutability check for manual runs; - require policy, wrapper, secret scan, and schema checks before Android verification starts; - generate the dependency report inside the already-warmed verification job instead of starting a second Android job; - remove the second standalone classpath-rerun job; - add `BOOKWAVE_CODEX_PREWARM=none` so CI does not run a redundant `gradlew help` before the real Gradle command; - keep four Gradle workers; - set `cancel-in-progress: false` for the manually-started acceptance workflow so a second click queues rather than terminating an expensive run; - retain current push-main behavior: fast-forward merges do not immediately repeat the accepted debug gate, while manual/scheduled Main remains standalone and runs `verifyDebug`; - update release documentation to describe the Forgejo CI contract. ## Validation Validated on exact HEAD: `0b18ca9332a97c2231c370532adf97c770402b39` Forgejo Actions run #50 / workflow run object 52: - result: **success**; - total wall time: **13m05s**; - policy correctly classified this PR as a build/classpath change; - verification mode: **full rerun**; - `verifyDebug --rerun-tasks`: **BUILD SUCCESSFUL in 11m41s**; - 1,184 actionable tasks, 1,184 executed; - Gradle wrapper validation: passed; - gitleaks 8.30.1: passed, no leaks; - committed Room schemas immutable: passed; - dependency report uploaded; - Room schemas uploaded; - quality reports uploaded; - debug APK uploaded. Previous full manual PR acceptance run took **26m18s**, because it performed a normal `verifyDebug`, bootstrapped a separate dependency-report job, and then performed another complete `verifyDebug --rerun-tasks`. This candidate therefore removes the duplicate verification while retaining the R-31 full-rerun guarantee when it is actually required. ## Scope This PR deliberately does **not** add a custom Android CI image or persistent Gradle cache. Those are good follow-up optimizations and can be measured independently after this workflow simplification is merged. No merge requested; owner will review and merge manually.
Author
Owner

APK picker cleanup added after review feedback:

  • Build APK now takes an optional PR number as a string instead of a generated static dropdown.
  • Blank builds the selected branch/ref; 52 or #52 resolves that open same-repository PR live through the Forgejo API.
  • Closed PRs and fork sources are rejected before privileged signing secrets are used.
  • The old picker synchronizer is retired and manual/no-op; it no longer reacts to PR open/close events or creates branches/PRs.
  • The old generator script is retired as a tombstone because the current Forgejo MCP does not expose file deletion.
  • Generated PR #51 was closed and branch mcp/apk-pr-picker deleted.

Validation: Build APK run #53 on exact HEAD 0488b21c3213c9195e33bb8f6caecba82399f508 successfully resolved input PR 52 to mcp/ci-gate-efficiency @ 0488b21c; the remainder of the signed debug smoke build is continuing.

APK picker cleanup added after review feedback: - Build APK now takes an optional PR number as a string instead of a generated static dropdown. - Blank builds the selected branch/ref; `52` or `#52` resolves that open same-repository PR live through the Forgejo API. - Closed PRs and fork sources are rejected before privileged signing secrets are used. - The old picker synchronizer is retired and manual/no-op; it no longer reacts to PR open/close events or creates branches/PRs. - The old generator script is retired as a tombstone because the current Forgejo MCP does not expose file deletion. - Generated PR #51 was closed and branch `mcp/apk-pr-picker` deleted. Validation: Build APK run #53 on exact HEAD `0488b21c3213c9195e33bb8f6caecba82399f508` successfully resolved input PR `52` to `mcp/ci-gate-efficiency @ 0488b21c`; the remainder of the signed debug smoke build is continuing.
alexander deleted branch mcp/ci-gate-efficiency 2026-09-18 18:08:45 +02:00
Sign in to join this conversation.
No reviewers
No labels
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set

Reference
alexander/Audiobookshelf-Manager-Claude!52
No description provided.