Add branch dropdown to PR verification #82
Loading…
Reference in a new issue
No description provided.
Delete branch "mcp/pr-workflow-branch-picker"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Makes manual PR verification use an explicit BookWave branch dropdown in addition to the PR-number input.
Changes:
bookwave_branchchoices topull-request.yml;run-namemetadata;Forgejo 16.0.4 still stores the top-level Actions run title from the literal workflow
name, so the PR number is guaranteed in the job titles (PR #… · Preflight,PR #… · verifyDebug) while the existingrun-nameremains ready for Forgejo support.Do not merge automatically.
Manual acceptance for this workflow change
Run Pull request once against PR #82.
Because the new dropdown exists only on this PR branch until merge, set Use workflow from to
mcp/pr-workflow-branch-pickerfor this one test. Then select:mcp/pr-workflow-branch-pickerfrom the dropdown82Expected: preflight validates the selected branch HEAD exactly matches PR #82, and the jobs render as
PR #82 · PreflightandPR #82 · verifyDebug.After this PR is merged, leave Use workflow from on
main; future PR checks will use the generated branch dropdown, so branch selection no longer depends on typing a ref.Do not run
Refresh workflow branch dropdownsas acceptance for this PR: that helper intentionally commits refreshed branch choices directly to main.Failed run #225 diagnosed and fixed
The run payload contained
bookwave_branch=main, even though Use workflow from wasmcp/pr-workflow-branch-picker. Checkout therefore correctly checked out main, and preflight rejected it because PR #82 HEAD is the feature branch.Fix now on PR #82:
mainis no longer offered as a PR source branch;__select_pr_branch__rather than silently choosing a branch;For the next acceptance run, use workflow definition
mcp/pr-workflow-branch-picker, explicitly choose source branchmcp/pr-workflow-branch-picker, enter PR82, and leave Force rerun off.PR status indicator added
The Pull request workflow now publishes a Forgejo commit status named BookWave / PR verification on the exact PR HEAD:
verifyDebugpass → green check on the PR;verifyDebugis also pinned to the exact SHA validated by Preflight so the visual status and the code actually checked are the same commit.A new run is required to exercise the status publisher; the previous failed run belongs to an older PR HEAD.
Hidden branch input + failed status publisher fixed
Latest runs #226/#227 exposed two Forgejo-specific issues:
bookwave_branchinput from this unmerged workflow revision. It silently supplied the workflow default instead.jq, but the defaultnode:22-bookwormjob image does not containjq.Current PR HEAD fixes both:
bookwave_branchis hidden/defaulted while testing an unmerged workflow, PR verification resolves the source from Use workflow from (FORGEJO_REF_NAME);main, the generated BookWave PR source branch dropdown remains the normal source selector;mainas the source is still rejected;jq;BookWave / PR verificationcommit status still publishes success/failure against the exact PR HEAD.For the next pre-merge test of PR #82: set Use workflow from to
mcp/pr-workflow-branch-picker, enter PR number82, leave Force rerun off. If Forgejo still does not show the BookWave source-branch field, that is expected for this unmerged workflow revision; the workflow will now usemcp/pr-workflow-branch-pickerfrom Use workflow from automatically.Workflow simplified after repeated dispatch failures
The custom
bookwave_branchinput has been removed entirely.PR verification now uses Forgejo's native Use workflow from ref as the branch source, exactly like the previously working workflow. The manual input schema once again matches
mainexactly: onlypr_numberandforce_rerun.The PR still adds:
verifyDebugpinned to that exact validated SHA;BookWave / PR verificationcommit status: green on full success, red on failure.Current PR HEAD:
b82a8e2ae4b65ef287247b5e525aa8dccfb3a39d.The latest recorded failure is still run #227 on older HEAD
91bdffb…; there is no Actions run yet for the current HEAD.Next test: Use workflow from = mcp/pr-workflow-branch-picker, PR number
82, Force rerun off. There is intentionally no separate BookWave source-branch field anymore.