Implement Slice 10 wider Hollow and Bellhollow content #14
Loading…
Reference in a new issue
No description provided.
Delete branch "mcp/slice-10-implementation"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Agent 40 implementation of the merged Slice-10 integration contract. Implements the generic conditional TravelEdge base-time override, Bellhollow Back Lanes payoff, Maren treatment, route/Survival/UI composition, validation, authoring documentation, and S10-001..040 acceptance coverage. Do not merge until independent Agent 50 acceptance.
Agent 40 implementation handoff for Agent 50
Starting main:
3ef3f10997da2ea12306f3669ef120cc38e02d63Implementation branch:
mcp/slice-10-implementationExact final HEAD:
eba8360634cad66f5f3bf9079b12215f9d56b7beSlice-9 dependency reconciliation is clean. The final merged Slice-9 code preserves the Slice-10 contract values and semantics: Survival rates/exertion, Cold Spring water, Bellhollow provisions, self-treatment, sentry Methods/danger, campsite known retrieval, travel bases, reset behavior, and the 172800-second loop. Later Slice-9 commits were hardening rather than a material contract change.
Implementation scope remains the approved minimum:
TravelEdge.baseTimeOverride, validated in repository JSON and editable/imported content;resolveTravelEdgeTimeresolver used by travel execution, Survival route projection/disclosure, and Routes presentation;poi_bellhollow_back_lanes, labelKnown shortcut in use;act_maren_treat_wounds/method_maren_treat_wounds: 600s, Treat/None, Health<100, 4 herbs, +30 Health clamped, repeatable while injured/affordable, zero Skill and zero exact/broad Mastery;Route/Survival acceptance is covered for 4320s pre-shortcut, 3120s post-shortcut, 1200s saving, 3420s prepared route and 2520s direct learned water-prep route. Tests also prove each 600s Light saving avoids 0.50 Hydration / 0.3333 Satiety and Maren's 600s None costs 0.325 Hydration / 0.25 Satiety solely through lived-time Survival.
UI work keeps actual effective route time primary; shortcut label and route familiarity are separate. Known source context is derived from legitimately visible actions and does not imply carried stock. POI hints are visible rather than hover-only. Map regions support pointer/click plus Enter/Space, visible focus, non-colour state wording/marks and practical >=44 CSS px hit targets. Browser acceptance covers 400×800 CSS px at 1.3× text with no horizontal overflow.
Automated acceptance names/proves every
S10-001throughS10-040; the full accepted Slice-9 Survival suite remains green.Exact-head Forgejo Actions run #360: all required contexts green:
No Tauri/platform paths changed, so the conditional desktop gate is not applicable. PR is currently mergeable and 0 commits behind
main.One CI repair was needed at the end: the new Herb Banks acceptance test initially asserted that +6 herbs was the only method grant, which incorrectly rejected the existing
rep_foraginggrant. The test was corrected to prove the +6-herb contract while preserving accepted existing progression.Review focus: selected-route timing is canonical/current-origin truth; the map's decorative bidirectional edge labels retain the existing de-duplicated-edge presentation. Touch uses the same large click/pointer hit target and no hover-only path; automated E2E explicitly covers keyboard/pointer and target size, while physical touch remains worthwhile acceptance evidence.
Agent 40 — Slice 10 acceptance-repair handoff
Repaired the three findings from the independent Slice-10 review. No merge performed.
Exact repaired state
main:3ef3f10997da2ea12306f3669ef120cc38e02d63a751ed9f5d08064b45ef840c6754ece907019ef6mcp/slice-10-implementationFinding 1 — editable TravelEdge fallback validation
validateEditableContent()now applies the same finite-positive rule to ordinaryTravelEdge.baseTimeCostSecthat repository/static validation already enforces.0, a non-number string payload, andInfinity.effectiveTravelTimeSec()and being clamped into valid-looking 1-second gameplay.Finding 2 — resolver fail-closed behavior
resolveTravelEdgeTime()now first verifies thatbaseTimeOverrideis a non-null non-array object.allConditionsMet()is called.baseTimeOverride: nullandconditions: [null]; both resolve the authored fallback base withactiveLabel: nulland normal Travel Mastery applied once.Finding 3 — current-status documentation
docs/development-status.md,docs/gameplay/survival.md,docs/gameplay/skill.md,plan.md, andCONTENT_AUTHORING.mdwith shipped Slice-8/Slice-9 reality and active Slice-10 PR #14.Future food/water survivalsection now describes the shipped lived-time Hydration/Satiety behavior.Verification
a751ed9f5d08064b45ef840c6754ece907019ef6:tests/slice10-integration.test.tsand the acceptedtests/slice9-survival.test.tssuite.Ready for fresh independent Agent-50 re-review at the exact repaired HEAD above.
Slice 10 — independent Agent-50 acceptance
Agent 50 has completed the fresh independent re-review of the repaired Slice-10 implementation and accepted Slice 10.
Accepted exact state:
a751ed9f5d08064b45ef840c6754ece907019ef6main:3ef3f10997da2ea12306f3669ef120cc38e02d63mcp/slice-10-implementationExact-head verification remains green on Forgejo Actions run #368:
The previous acceptance findings were repaired before this review. No repository changes are being made after acceptance so the accepted exact HEAD remains unchanged.
SLICE 10 ACCEPTED — ready for manual merge by the project owner.